Skip to content

Add endpoints to get, create and delete silences#798

Merged
Abigail-Yates merged 16 commits into
mainfrom
silence-alerts
May 19, 2026
Merged

Add endpoints to get, create and delete silences#798
Abigail-Yates merged 16 commits into
mainfrom
silence-alerts

Conversation

@Abigail-Yates
Copy link
Copy Markdown
Collaborator

Turn alerts off and on using silences

@Abigail-Yates Abigail-Yates self-assigned this May 12, 2026
Comment thread src/murfey/server/api/session_info.py Fixed
Comment thread src/murfey/server/api/session_info.py Fixed
Comment thread src/murfey/server/api/session_info.py Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 16.36364% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.60%. Comparing base (14aab9f) to head (c8ba61c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
- Coverage   52.33%   50.60%   -1.73%     
==========================================
  Files          96       96              
  Lines       10324    10745     +421     
  Branches     1357     1463     +106     
==========================================
+ Hits         5403     5438      +35     
- Misses       4642     5006     +364     
- Partials      279      301      +22     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/murfey/server/api/session_info.py Fixed
changed 'microscope' to 'instrument_name' for consistency. Alert
silencing endpoints instrument_name type is now MurfeyInstrumentName for
validation.
Comment thread src/murfey/server/api/session_info.py Fixed
Comment thread src/murfey/server/api/session_info.py Fixed
Comment thread src/murfey/server/api/session_info.py Fixed
Comment thread src/murfey/server/api/session_info.py Outdated
Comment thread src/murfey/server/api/session_info.py
Comment thread src/murfey/util/config.py Outdated
Comment thread src/murfey/server/api/session_info.py Fixed
Comment thread src/murfey/server/api/session_info.py Fixed
@Abigail-Yates Abigail-Yates changed the title Add methods to get, create and delete silences Add endpoints to get, create and delete silences May 14, 2026
Comment thread src/murfey/server/api/session_info.py Outdated
Comment thread src/murfey/server/api/session_info.py Outdated
Copy link
Copy Markdown
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks for addressing all the comments

@Abigail-Yates Abigail-Yates merged commit 85f45f8 into main May 19, 2026
17 checks passed
@Abigail-Yates Abigail-Yates deleted the silence-alerts branch May 19, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants